Hello everyone. 2017 was my first attempt at a formula as well as my first go at Ruby stuff. You can see my PR here: https://github.com/Homebrew/homebrew-core/pull/17795
It was rejected for having “numerous issues” but then ilovezfs stepped in to provide some guidance (though I am still uncertain what the numerous issues were). Ultimately we decided to make this a third party library and so far that has worked out. Now though, looking at the list of installs, my formula was installed ~100 times in the last year. That’s not a ton, but it’s a decent amount for how specialized the product is.
The advice I am looking for is whether or not I should attempt a re-PR to integrate it into brew instead of being a third party formula. This is an Oracle product (so it’s not just some no-name micro-app), and because of how tedious the installation process is, I created a brew formula and chocolatey package to help the community.
The main issue initially was the software jar files were only available through a password protected link. It appears that the password has since been removed, but part of the installation process is to unpack a jar file to use 2 other jar files inside (as I said, tedious). The easiest solution for me was to do this in advance and host the jar files in my repo to be downloaded.
So with that:
- Is this a valid product to re-attempt a PR?
- Can a formula execute cli commands like:
jar xf my.jar
and move those files to the right folder location and delete the non-relevant files?
- Or am I allowed to host the jar files like I’ve been doing
- What else is wrong with my formula that would be an issue keeping it from being approved
Also note, one of the issues was the license. They (Oracle) just copy pasted from another related product… So the comment (https://github.com/Homebrew/homebrew-core/pull/17795#issuecomment-327981418) about the license is actually for a different product. I’ve received direct blessing from the Oracle team in charge of this software, and can get a formal letter from them if needed to validate my work.
Thank you in advance for your help.